Open raven2cz opened 2 years ago
i like the overall style a lot, but could we try couple of slightly darker variations for the starting gradient color on the very top?
@actionless There are proposals. Choose your "destiny"
they all still lack a little bit of contrast:
from light i didn't liked much neither, they still got too light top color
from dark dark-5 and dark-1, but again, i'd like top menu color still to be lighter
and i see you're adding new font - make sure that all text then would be using the new font family, it would be like looking tidier (you could additionally play with font-weights)
@actionless Maybe I have idea...
previous i liked more, design was good, just top-most color should be like 5-10% more contrast
I have no directly contrast parameter in color, but I can change saturation which I increase about 10%. In addition there is necessary to play with alpha channel. There are two images with increased saturation. C1 image has alpha channel 30, more opacity (more original color). C2 has alpha channel to 20, less opacity (less original color).
mb smth in the middle of these two? 😸
mb smth in the middle of these two? smile_cat
Demo updated. Font family used just one.
Main problem was light theme, I tried around 40 settings and this is best which I found. For light theme is maybe to remove gradient for light or kept this one.
previous gradient color on light theme was good, it just need to be darker, not different color, just darker and that's it
Increase darker just few percent in value
and 2 variants of alpha color.
i think light-2-B-darker-60 is alright, but looking on it i want to move menu itself (and light/dark switch) like 10 or so pixels higher (without moving the gradient itself)
and could we also get rid of using underline for currently selected menu item, please, and think of smth different for that, like for example using different color and (background color or gradient) for the selected menu item
also a technical problem - with certain window width github link is overlapping the "home" link and attempts to click Home open github instead:
i'm not 100% sure, but mb that could be solved by adjusting z-indexes for github strip and menu
Done.
About correction. Z-order is already used, because "fork me" needs highest z-order. I have just one solution, to switch to "menu" button only if the width is less than nav-links buttons. I tested now in browsers and mobiles. It seems ok now.
All next points are done. Selected menu item too. About possibility to change color-background
. We will see. I used color and width of text first. Color-background is very dominant change in whole design.
1) now the menu get hidden into button when the window is quite wide - that normally should happen only on obviously-mobile widths - even in previous commits of this prototype that was happening too early, but now it's even more
2) when scrolling down menu shade totally disappearing, this looking a bit inconsistent, i think it should still persist, mb not as gradient but as a lighter, solid color:
3) position of dark/light button should be consistently in top right corner when scrolling 4) same for menu itself - after doing pt.3 that shouldn't be hard
5) it feels very weird to have site logo below the menu, i recommend moving it permanently to the left (like on scrolled-down menu layout) for all the pages except for Home page (there showing it below menu sorta works as in such case logo looks like part of page layout, not header)
and also i'm not sure about github ribbon - back in the day when it was added it was like a sign of project being modern and instead of using self-hosted svn using public git repo with collaboration possibilities
nowadays it's sorta a standard already, so i don't really think it's still reasonable to additionally advertise the fact we use github, what do you think @Elv13 ?
the reason i wanna get rid of it, because it makes the header layout possibilities more complicated
Uch. All points will be much more bigger problems now.
Add 1) It is my correction to your reported bug. "Fork me" needs highest z-order, because it has to be independent on the navbar. If it has lower z-order, it cannot be press. There is just one choice, to replace nav-links with menu button - if the width of buttons is smaller and to close to "fork me". If we want "Fork me" in the left side, we haven't other choice. Another solution is completely remove "Fork me" from top segment.
Add 2) It is my design. I don't want gradient in the scrolling menu. Do you want it? This navbar is much more smaller and has different behavior. I think that it is consistent. If we will apply some gradient, it needs different configuration for it, because the it is rolling navigation bar - it means different feature.
Add 3) It is my design again. The animation for left logo and right dark/light button has to be consistent. If there will be just animation for left logo, it is asymmetric animation and very bad for eye. I already play with it and it is not good idea.
Add 4) It is very big problem. It change whole implementation. Because I cannot use simply flexbox which measure space between components. I haven't technical solution for this requirement. I can find some solution for it, but it will change whole implementation.... Problem here is that flex measure symmetric spaces between inserted elements. And there is now visible left logo, the space between logo, nav-links and right button has need same space-between
. You want some asymmetric space, which cannot be fixed
, because you have dynamic width of window.
Maybe to drop whole flex and use some center in left, center and right parts....I haven't idea now for this point.
Add 5) Menu is independent on the page content. You want cross concern between ikiwiki template and menu component. I cannot make this change. Template has to be simple, I have bound hands with ikiwiki. The change has to be consistent for all pages, not just some home or something.
The complete removing "fork me" button very help.
I'm not sure with this Draft MR now. It seems that there is much more problems against previous design. So, I cannot make all these points. Check my responses. Some of them is possible to solve. Some can take much more time. And some is not possible to solve.
I don't want gradient in the scrolling menu. Do you want it?
i think it should still persist, mb not as gradient but as a lighter, solid color
regarding the rest - yup, smth like space-between or few different media-queries for different screen width would help there
but let's first get some feedback regarding Fork ribbon - as it would make things easier to plan if we can make decision to leave it or get rid of it - and so next we could discuss everything more detailed from that point
Yes, we will wait.
In addition, think about possibility to remove dynamic "rolling" nav. Maybe it is a luxury which we don't need because we have very small content in each page. If we remove dynamic nav. We have free hands with more variants for other pages against home. I play just ideas.
There is just some concept of top bar very similar with actual style.
visually i like that thing with subtle color and/or gradient - i think it's good visual direction to move, that thing on last screenshot looks like default theme of old Bootstrap version from like 2010
so do we still need that github ribbon @Elv13 ? (https://github.com/awesomeWM/awesome-www/pull/177#issuecomment-1264658274)
@sclu1034 Many thanks for your technical overview. It is very helpful! I will implemented it step by step, maybe I will have some additional questions, but in common, it is clear.
Before implementation. We will wait with ribbon to @Elv13 opinion too.
But I have two important questions to you that were not answered. I know that you mainly focused to technical part. If this draft / idea is good approach or not. Mainly two points we have to discuss
I personally like large logo in home page. Next tabs can be without this logo, it will be some inconsistency, but maybe still acceptable. But still top menu is top menu. In home tab, the logo will be still under it.
In addition, if you add the line to fixed menu, there will be very ugly to show animation for menu logo. My main design concept was that the large logo disappears and "in same time" the logo moves to the menu bar with animation to the left. But if we don't want the logo in next tabs, this idea goes to dill.
We really have to discuss what we want.
For the home page, I do like the large logo. But I wouldn't want it on the other pages.
As for navbar above or below the logo, I don't have any strong preference. I'd be fine if it was moved back below the logo, and the animations adjusted accordingly.
It means that we have to create some line between main logo and top menu
I don't see any reason why a line should be considered necessary. The gradient doesn't work as a separator either, so not having the line is exactly what we have right now.
However, simply applying the "scrolled" style even in the "not scrolled" position looks like a valid option to me, too.
Top menu is present "permanently". It was aim, but for mobiles and small screens it can take important space.
I didn't realize that it was actually supposed to reappear while scrolling up. While scrolling down slowly, I saw that the same animation started as on desktop, but that the bar wouldn't stay in place, and assumed that it was a bug.
If the navbar is supposed to disappear on mobile, then it should do so without animation (i.e. simply scroll out of view). In fact, I think in that case, it would be easiest to just disable the entire "dynamic" portion on mobile and just have it fixed at the top.
However, if its size was reduced, I wouldn't see a problem with the bar staying visible on mobile (i.e. same behaviour as on desktop). Right now, it definitely is too big for mobile screens, and mostly empty anyways.
A few more things I noticed:
@sclu1034 I have one technical question. From prev conversation, home is selected (it is "about" selection); we want large full logo and menu under it, theme checkbox in right corner. After scrolling, the logo has to disappear and shows the left small logo in left corner. For other non-about tabs, we don't want large logo, but immediately logo in left side, menu middle and checkbox right.
How to solve it? I have idea, that the large logo will be part of your described flex layout, and inserted to middle block, but new style for middle block to use first large logo and menu under it in the middle block. Question is if the hiding in some cases correctly move menu to top if the logo isn't required.
We have this generated "trick" with ikiwiki <TMPL_VAR NAME="title">
which can be used for correct selection of active css style which can be used for styling between about
and not:
about solutions.
@actionless According to our discussion - navbar and css improvements issue #159.
There is new prototype 4. With complete new design for navbar and full support for mobile devices (overlay menu support). Fixes for few css "gaps" and small improvements according to linked pags in #159.
From my side, it is better design.
But of course it takes some screen space, the navigation is still available, it has cons and pros.
https://raven2cz.github.io/awesome-www/