Open nuckle opened 4 months ago
i think in your rule you need to also set border_width to 0
i think in your rule you need to also set border_width to 0
I did, but the popup feels weird.
Sometimes it appears on the wrong side
Or it'll be empty (border to show that there is actually a window)
in that case mb rule is not actually matching that popup:
rule = { class = "Firefox", role = "Popup", },
in that case mb rule is not actually matching that popup:
rule = { class = "Firefox", role = "Popup", },
It actually changes when I change the values inside the rules, so the rule is matching. I checked the windows properties and it's definitely matching. But the windows itself is messed up. Sometimes position is wrong, window is empty, or it flickers. On DE (cinnamon) it works fine. Tried different profiles in Firefox, versions, result is the same
in that case the good solution would be to unmanage those windows at all, by adding callback to a rule, which would call https://awesomewm.org/doc/api/classes/client.html#client:unmanage on the client
Am I doing this right? Because I get an error /usr/loca/sare/aweosme/lib/awful/client/focus.lua:118 invalid object
when I spawn the popup
rule = {
class = "Firefox",
role = "Popup",
},
properties = {
fullscreen = false,
maximized = false,
titlebars_enabled = false,
skip_taskbar = true,
border_width = 0,
},
callback = function (c)
c:unmanage()
end
I tried to play around with callback, but no matter what I do, I still have something like this
https://github.com/awesomeWM/awesome/assets/37220313/e2ca1c08-7ea7-40f1-bb5a-72bedba51f23
Am I doing this right? Because I get an error /usr/loca/sare/aweosme/lib/awful/client/focus.lua:118 invalid object
please provide full trace, not just error message
I tried to play around with callback, but no matter what I do, I still have something like this
yeah, your real error is 2024-02-20 13:31:58 W: Trying to emit signal 'manage' on invalid object
try some guard like, if c then
or first do a delayed call (and next if c
guard inside delayed call): https://awesomewm.org/doc/api/classes/gears.timer.html#gears.timer.delayed_call
also, AFAIK JetBrains and few other java-based IDEs have similar problems with their popups, mb some advices from those topics would also help: https://github.com/awesomeWM/awesome/issues?q=label%3AJava+
I kinda fixed it. Still not perfect but for me it's enough. I also checked if the issue happens in Firefox Developer (from Nix) and it seems to be way better than regular version of Firefox.
{
rule = {
class = "Firefox",
role = "Popup"
},
properties = {
border_width = 0,
focus = false,
focusable = false,
valid = false,
has_titlebar = false, -- custom property to disable titlebar
placement = awful.placement.restore,
ontop = true,
size_hints_honor = true
},
callback = function(c)
c.focus:raise()
c.y = c.y - 25
end
},
{
rule = {
class = "firefox-aurora",
role = "Popup"
},
properties = {
border_width = 0,
placement = awful.placement.restore,
has_titlebar = false -- custom property to disable titlebar
}
}
https://github.com/awesomeWM/awesome/assets/37220313/93f43d9f-afe0-431d-bf54-422af69010cd
https://github.com/awesomeWM/awesome/assets/37220313/afb3614e-af27-456f-9d72-58dba4cbd251
Output of
awesome --version
:How to reproduce the issue:
Actual result:
Default system awesomeWM config
Expected result:
Cinnamon
Tried to fix it using rules, but it still looks weird and buggy