Notification always executes the action

awesomeWM / awesome

awesome window manager

https://awesomewm.org/

GNU General Public License v2.0

6.39k stars 597 forks source link

Notification always executes the action #3944

Open ayushjaipuriyar opened 2 months ago

ayushjaipuriyar commented 2 months ago

awesome v4.3-1655-gad0290bc1-dirty (Too long)
 • Compiled against Lua 5.4.7 (running with 0.9.2)
 • API level: 4
 • D-Bus support: yes
 • xcb-errors support: no
 • execinfo support: yes
 • xcb-randr version: 1.6
 • LGI version: /usr/share/lua/5.4/lgi/version.lua
 • Transparency enabled: yes
 • Custom search paths: no

How to reproduce the issue:

A notification from any app that supports actions, let's say slack.

Actual result:

As soon as the notifications arrives, the app is forced to open even when no actions were taken.

Expected result:

The notification should just time out if no actions are taken.

This wasn't the case earlier, but in the recent commits this started to happen.

Elv13 commented 2 months ago

Can you check with bustle is the action is indeed taken rather than this being something else? Also, do you use the legacy notification module or the new one (aka, do you have a naughty.connect_signal("request::display"... section in your config, which indicates the new one is used)

ayushjaipuriyar commented 2 months ago

Can you check with bustle is the action is indeed taken rather than this being something else? Also, do you use the legacy notification module or the new one (aka, do you have a naughty.connect_signal("request::display"... section in your config, which indicates the new one is used)

I am using the new one, as I have that line in my configs. And yes in bustle, it shows like

Notifications arrived
3 seconds have passed, the time I have set as timeout of notifications
The notification actions invoked is called
the notifications action closed is called.

numkem commented 2 months ago

I'm on current master and I've noticed that even when you right click on the notification (used to just close it) now it execute the action anyway. Might be related?

ayushjaipuriyar commented 2 months ago

I'm on current master and I've noticed that even when you right click on the notification (used to just close it) now it execute the action anyway. Might be related?

could be we might have been able to figure out which may be causing this Reddit link pull request

Aire-One commented 2 months ago

I think https://github.com/awesomeWM/awesome/pull/3906 tries to fix this behavior.

Elv13 commented 2 months ago

I merged the PR, please update and retry

ayushjaipuriyar commented 2 months ago

I merged the PR, please update and retry

Apparently did not fix the issue. Currently, as soon as the timeout of the notification finishes the action is executed.