awesomefoundation / awesomebits

This is the source code for the Awesome Foundation website
https://www.awesomefoundation.org/
GNU Affero General Public License v3.0
62 stars 53 forks source link

Fix/remove weird chapter_id code #534

Open jcn opened 1 year ago

jcn commented 1 year ago

The fix_chapter_ids code is weird and should be removed/fixed but I'm not sure the implications of it. When viewing project pages, this before_action changes the id param from the full param (with the title) to just the id.

https://github.com/awesomefoundation/awesomebits/blob/master/app/controllers/application_controller.rb#L56-L66

This code was put in a long time ago and I'm not sure how necessary it is any more. It may have just been transitional when moving from chapter ids to friendly_id slugs.