search

awesomemotive / EDD-Digital-Store

Digital Store WordPress Theme for Easy Digital Downloads
http://easydigitaldownloads.com/digital-store/
GNU General Public License v2.0
26 stars 12 forks source link

2.7 EDD results in "Loading" text becoming visible #65

Closed brashrebel closed 7 years ago

brashrebel commented 7 years ago

https://cloudup.com/cm6uSkuKc7Y

Reported by a customer and just replicated locally. Digital Store does not use EDD core's CSS: https://github.com/easydigitaldownloads/Digital-Store/blob/master/functions.php#L100

and that is what defines the styling of the .edd-loading element. So we either need to use EDD's CSS or replicate the relevant rules.

pippinsplugins commented 7 years ago

Digital Store is no longer maintained so I propose wontfix and close here.

pippinsplugins commented 7 years ago

OR we could go ahead and merge the PR that @brashrebel did but not deploy it anywhere. If a site is still using the theme, they can grab the changes here.

SeanTOSCD commented 7 years ago

@pippinsplugins Tested. The PR works for me. I'm good with merging and letting it be.

@brashrebel Can you go ahead and version bump as well? Might as well continue to maintain that.

brashrebel commented 7 years ago

Just pushed that. My bad. I didn't realize this theme wasn't getting updates. I was just about to open another issue too. I think I will anyway just to keep a record but won't pursue a patch.

pippinsplugins commented 7 years ago

We may end up needing to revert the core change. There's now been reports of this problem in 4-5 different themes. Basically anyone that modified edd.css doesn't see the new icon :(

SeanTOSCD commented 7 years ago

I'll dig into this today. Definitely not specific to Digital Store but I have to figure out why it's happening. I don't wanna revert if we don't have to.

SeanTOSCD commented 7 years ago

Fixed in EDD, so this won't happen in Digital Store anymore. But the changes made to Digital Store are still fine considering they update some other relevant CSS. Closing this and merging the PR. Thanks @brashrebel!