awesomemotive / WP-Mail-SMTP

The most popular WordPress SMTP and PHP Mailer plugin. Trusted by over 3 million sites.
https://wordpress.org/plugins/wp-mail-smtp/
GNU General Public License v3.0
55 stars 35 forks source link

Tab support enhancement on setup wizard #127

Closed heybran closed 10 months ago

heybran commented 1 year ago

Expected Behavior

Setup wizard step 2

Encryption radio should show a focus indicator (outline) to let users know it is being currently focused by Tab key.

Setup wizard step 3

Similar to previous feedback, non-disabled email features checkbox should show styles difference when they're tabbed into by keyboard.

Setup wizard step 4

Yes, count me in checkbox should have focus styles applied when tabbed into by keyboard.

Current Behavior

Setup wizard step 2

Users do not know when Encryption radio is tabbed into as it has no focus styles.

Screenshot 2023-10-03 at 16 27 39

Setup wizard step 3

Non-disabled email features checkboxes has no focus styles.

Screenshot 2023-10-03 at 16 34 39

Setup wizard step 4

Yes, count me in checkbox has no focus styles applied.

Screenshot 2023-10-03 at 16 41 55
heybran commented 1 year ago

Tried to work on this issue, but got an error when running composer build-lite.

> wp-mail-smtp@3.9.0 gulp
> node ./node_modules/gulp/bin/gulp.js composer:create_vendor_prefixed_folder

[17:31:15] Using gulpfile ~/codes/docker/breeze-menu/wp-content/plugins/wp-mail-smtp/gulpfile.js
[17:31:15] Starting 'composer:create_vendor_prefixed_folder'...
[17:31:15] Finished 'composer:create_vendor_prefixed_folder' after 88 ms
Loading composer repositories with package information

  [RuntimeException]                                                                         
  The `url` supplied for the path (.packages/composer/phpcs-diff) repository does not exist  

Same error when I run composer install, if I may know what do I need to do to set up the dev environment?

My composer version is 1.10.27, and my Node is v20.3.1.

What I did was:

Do I need to install this package .packages/composer/phpcs-diff beforehand? If so, how do I find that package to install? Thanks a lot.

alexander-sakal commented 1 year ago

Hello @heybran

Thank you for opening this issue and trying to resolve it!

Unfortunately, currently, development of the Setup Wizard in the public repository is not possible. We'll try to implement it in one of our future updates.

heybran commented 1 year ago

Hello @alexander-sakal

Thank you for letting me know.

alexander-sakal commented 10 months ago

Hello @heybran. We enhanced tab support in the Setup Wizard in our latest release (v3.11.0). Check it out and thanks for bringing it up!