search

awesomemotive / WP-Mail-SMTP

The most popular WordPress SMTP and PHP Mailer plugin. Trusted by over 3 million sites.
https://wordpress.org/plugins/wp-mail-smtp/
GNU General Public License v3.0
55 stars 34 forks source link

Misleading doc about SSL vs STARTTLS config #132

Open gggeek opened 5 months ago

gggeek commented 5 months ago

I think the comment on line https://github.com/awesomemotive/WP-Mail-SMTP/blame/023e5bc91963e0ddc1b3955e60d0de972fdc3604/wp_mail_smtp.php#L71 is wrong, or at least misleading.

Looking at the phpmailer code, it seems to be the opposite: WPMS_SSL='ssl' -> an implicit-ssl connection will be used to connect the server (where ssl might be tls 1.2 in fact) WPMS_SSL='tls' -> a plain connection + starttls will be used

gggeek commented 5 months ago

While at it, the note for WPMS_SMTP_AUTOTLS "True turns it on, false turns it off" might be detailed a bit more: it means "do use startls when the server declares support for it, openssl is available to php and the connection is not using implicit ssl"