instantiate MailCatcher with true so exceptions get thrown

awesomemotive / WP-Mail-SMTP

The most popular WordPress SMTP and PHP Mailer plugin. Trusted by over 3 million sites.

https://wordpress.org/plugins/wp-mail-smtp/

GNU General Public License v3.0

55 stars 35 forks source link

instantiate MailCatcher with true so exceptions get thrown #45

Closed websupporter closed 5 years ago

websupporter commented 5 years ago

WordPress relies on the PHPMailer instance is instantiated with true to tell PHPMailer to throw exceptions. This way WordPress can catch those exceptions and fire the wp_mail_failed hook

Closes #44

slaFFik commented 5 years ago

🤦‍♂️ Merged without paying attention to the branch :(

websupporter commented 5 years ago

Should I have made the PR against develop? Somehow it looks like its neither in master nor develop now

slaFFik commented 5 years ago

Yeah, I've reverted. It will be released, don't worry.

websupporter commented 5 years ago

Thanks a lot @slaFFik