Fix PHP warning - Githubissues

awesomemotive / all-in-one-seo-pack

All in One SEO plugin for WordPress SEO

https://aioseo.com

339 stars 155 forks source link

Fix PHP warning #3025

Closed arnaudbroes closed 4 years ago

arnaudbroes commented 4 years ago

Issue #3014

Proposed changes

Fix for issue where the paginated homepage (set to show latest posts) doesn't return a queried object for the robots meta code.

Types of changes

Bugfix (non-breaking change which fixes an issue)

Checklist

[x] I've selected the appropriate branch (ie x.y rather than master).
[x] I've created an appropriate title, descriptive of what the PR does.
[ ] Travis-ci runs with no errors.

Testing instructions

First, create a new website and install All in One SEO Pack v3.3.
Create 15 or so posts (use https://github.com/arnaudbroes/endless-post-creator if you're lazy) so that the homepage is paginated and navigate to the second page. Two errors appear.
Install the PR and confirm that the issue has been fixed.

Extra comments

Also replaced global $aioseop_options with a class variable to remove a few redundant lines.

michaeltorbert commented 4 years ago

This is tested and is good.