Fix broken counter and snippet preview from WP 5.3 and AIOSEOP 3.3 - Githubissues

awesomemotive / all-in-one-seo-pack

All in One SEO plugin for WordPress SEO

https://aioseo.com

339 stars 155 forks source link

Fix broken counter and snippet preview from WP 5.3 and AIOSEOP 3.3 #3034

Closed michaeltorbert closed 4 years ago

michaeltorbert commented 4 years ago

Issue #3033

Proposed changes

In 3.3 we refactored the snippet preview and counter javascript code.

Types of changes

What types of changes does your code introduce?

Bugfix (non-breaking change which fixes an issue)
Improves existing code

Checklist

[x] I've selected the appropriate branch (ie x.y rather than master).
[x] I've created an appropriate title, descriptive of what the PR does.
[ ] Travis-ci runs with no errors.
[ ] I have added tests that prove my fix is effective/my feature works or have created an issue for it (if appropriate).

Testing instructions

Install the latest stable version of All in One SEO Pack (3.3.1.1) and WordPress 5.3.
Verify the bug (broken snippet preview and counter)
Verify this fixes it (clear your cache)

michaeltorbert commented 4 years ago

@EkoJR This is broken again with your changes.