search

awesomemotive / all-in-one-seo-pack

All in One SEO plugin for WordPress SEO
https://aioseo.com
339 stars 155 forks source link

Remove conditional checks for advanced GA settings in free #3058

Closed arnaudbroes closed 4 years ago

arnaudbroes commented 4 years ago

Issue #3056

Proposed changes

Removes conditional checks for two advanced GA settings in free since the Google Tag Manager field is a Pro feature and thus these conditional checks need to be added through Pro.

Types of changes

Checklist

Testing instructions

Build this PR together with the one in Pro - https://github.com/semperfiwebdesign/aioseop-pro/pull/575

wpsmort commented 4 years ago

@arnaudbroes This has failed Grunt.

arnaudbroes commented 4 years ago

@arnaudbroes This has failed Grunt.

That's fine and happening because of an update to Grunt (we've addressed this in the 3.4 branch - https://github.com/semperfiwebdesign/all-in-one-seo-pack/pull/3044) but 3.3.x branches will fail.

wpsmort commented 4 years ago

This is tested and is good.