Improve payment method icons in settings

[SeanTOSCD]

Briefly discussed here: https://easydigitaldownloads.com/support/topic/card-logos-for-maestro-diners-china-union-and-jcb/

@chriscct7 mentioned that for some, the common PayPal defaults are not included. Just starting the discussion... if there's going to be one.

[pippinsplugins]

Flagging for 2.1.

[evertiro]

Initial step toward making this easier... Between this filter and the existing edd_accepted_payment_icons filter, you can now programmatically add whatever cards you want, as well as replace images of the existing cards.

I'd suggest coupling this with a free plugin to allow simple adding/editing of credit cards.

[pippinsplugins]

The icons aren't always credit card types, sometimes they are PayPal, Payza, Bitcoin, or others. Any filter introduced should respect this and avoid anything like edd_accepted_card_

[evertiro]

really good point....

[evertiro]

Tweaked it to match the format used for the settings array

[pippinsplugins]

Definitely a good improvement in #2423. Still room for more consideration.

[evertiro]

@pippinsplugins Please tell me what you want to see improved beyond that and I'll be more than happy to implement!

[pippinsplugins]

At this point I think it's just a matter of deciding if we should add additional payment method icons for other card types.

We could also dramatically improve how the payment method icons are presented in settings. Instead of just showing checkboxes, what if we were to show the icons themselves to make it more clear what is getting enabled?

[evertiro]

I'd actually been debating going a step further and writing a simple free plugin to manage card images on a per-gateway basis through the dashboard. Thoughts?

[pippinsplugins]

I'd like to start with showing the icons in settings then possibly expanding from there.

[evertiro]

That's no fun :smile: but ok

[pippinsplugins]

This is my plan (I'll fix alignment obviously):

[pippinsplugins]

Thoughts everyone?

[evertiro]

Bad idea... at least somewhat. that's going to start looking REALLY chaotic if someone (either through a gateway extension or the provided hooks) adds a few more icons.

[evertiro]

If you're going to do horizontal positioning, we need to have some sort of standardized 'column width' to keep things from getting jumbled

[pippinsplugins]

I don't see it getting really jumbled with custom icons. As long as devs use the standard icon size, there's no reason it would display poorly.

Personally I'd rather see a lot of icons in a line than a lot of icons in a list that makes the page really long.

[chriscct7]

I sort of agree with Dan. You need to standardize the column widths. Maybe 4 columns at 25% each. Also we need to force the images used to be resized to the same width/height. If an extension adds more card icons, we dont want those images being huge.

On Mon, Jul 21, 2014 at 5:53 PM, Ghost1227 notifications@github.com wrote:

If you're going to do horizontal positioning, we need to have some sort of standardized 'column width' to keep things from getting jumbled

— Reply to this email directly or view it on GitHub https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/2409#issuecomment-49671371 .

[evertiro]

Generally I'd agree, but put an icon with a label the length of amex below visa and all of a sudden things are scattered all over. I think we either need a standardized column width, or something like a chosen multiselect dropdown with the icons inline

[pippinsplugins]

I am forcing them to the same size. My issue with the forced / standardized width is how it will display on large screens. 25% works well on smaller screens but will look poor on a 24" or 27" screen. Obviously we could use media queries, but it's a slippery slope.

[pippinsplugins]

We've decided to leave this as is for now as it is a significant improvement over what it currently is.

If we do start to notice issues, we'll address again.