search

awesomemotive / easy-digital-downloads

Sell digital downloads through WordPress
https://easydigitaldownloads.com
GNU General Public License v2.0
862 stars 475 forks source link

nostates #2963

Closed bseddon closed 9 years ago

bseddon commented 9 years ago

Updated to 2.2.3 yesterday. Now when I selected a country without any states I see 'nostates' shown. While this is correct, it is inelegant.

image

Could the field just not be hidden?

But I have a more fundamental concern about the change made in this release. I tried to raise my concern (in a not very articulate way) by asking if there was a specification for this change in the discussion thread.

By prescribing countries and states you have removed the flexibility to cope with the real world. Now we have to fit in a world that matches with your world view. While the UK does not have 'states' we do have regions (England, Scotland, Wales and Northern Ireland) and counties. Counties in particular are a normal part of a UK mailing address. I live in the county of SURREY in the UK and my proper address includes the county in which I reside. It is

16 Lynton Road New Malden SURREY KT3 5EE United Kingdom

This is not unusual and most countries in Europe have some kind of regional component, above a city, to their address. The state field would have often been used to collect this additional address element in an unstructured way. Now that is not possible.

I think there has been an attempt to model the changes after Woo Commerce. While Woo Commerce does not show a county field for the UK it does at least hide the redundant field.

Is this a killer? No, but presenting 'nostates' makes it look like it was conceived during amateur hour. I would like to see the site owner given the option to present an unstructured, non-validated field in which a buyer is able to enter this additional address information. It would be great if the name for the address element could be named. 'State' works in some countries, 'County' would work for the UK. 'Department' for France and so on. At the very least it would be good to be able to show something other than 'nostates'

cklosowski commented 9 years ago

Can you try with no other plugins active? Seems like you're having a conflict somewhere...because I'm getting the intended results:

image

bseddon commented 9 years ago

I apologize I'm wrong. In fact I was seeing the problem in 2.2.2 which emits this when the country is changed:

includes\ajax-functions.php: $response = 'nostates';

I need to do a better job of remembering which test site I'm using

cklosowski commented 9 years ago

No worries! Thanks for double checking.