awesomemotive / easy-digital-downloads

Sell digital downloads through WordPress
https://easydigitaldownloads.com
GNU General Public License v2.0
864 stars 475 forks source link

Add shortcode to publish metabox #3339

Closed amdrew closed 9 years ago

amdrew commented 9 years ago

Here's a nice way of showing the shortcode (From GiveWP, see far right). We should consider doing this for EDD and possibly even go as far as removing the shortcode from the main downloads page. Would make it cleaner.

screen shot 2015-04-09 at 3 25 40 pm

amdrew commented 9 years ago

Or do it like this at least which is much nicer IMO

screen shot 2015-04-09 at 3 36 32 pm

chriscct7 commented 9 years ago

+1

On Thu, Apr 9, 2015 at 4:37 PM, Andrew Munro notifications@github.com wrote:

Or do it like this at least which is much nicer IMO

[image: screen shot 2015-04-09 at 3 36 32 pm] https://cloud.githubusercontent.com/assets/52581/7076329/3e72afca-dece-11e4-988b-a6a6b6a29f8a.png

— Reply to this email directly or view it on GitHub https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/3339#issuecomment-91349451 .

pippinsplugins commented 9 years ago

I really like this.

sunnyratilal commented 9 years ago

:+1:

cklosowski commented 9 years ago

Yes, I personally would lot to remove it from the list table, or make it hidden until a click. We're wasting a ton of space with that column.

spencerfinnell commented 9 years ago

Agreed @cklosowski -- even removing the text/style/color attributes would help.

I know I'm not the average user but I know I've never used it. Might be better as a quick plugin or code snippet to add it to the columns for those who tend to use it a lot.

evertiro commented 9 years ago

Something like this?

spencerfinnell commented 9 years ago

Maybe a "View" link to toggle the input? Similar to the Edit/Browse links above it.

evertiro commented 9 years ago

I just copied Andrew's example... but...

evertiro commented 9 years ago

Something like this @spencerfinnell?

mindctrl commented 9 years ago

This is cool, though you could argue a shortcode that displays a purchase link has nothing to do with publishing the content and is unrelated to everything else in that box. Edit: either way, it's better than the shortcode being listed in the table view.

evertiro commented 9 years ago

TECHNICALLY you could argue that the shortcode makes it possible to 'publish' the product wherever you want. But... it wasn't my idea to put it there, I just did the implementation. :wink:

evertiro commented 9 years ago

Also, there isn't really anywhere it's 'better' suited on that page, and adding a whole new metabox for it is just silly.

mindctrl commented 9 years ago

@ghost1227 you could, but the purchase_link shortcode doesn't output all the product information. [downloads ids=xx] would make more sense in that context. But I agree that it's likely the best place on that page all things considered.

pippinsplugins commented 9 years ago

I think I'd rather see the short code in the pricing meta box, or perhaps the settings box.

evertiro commented 9 years ago

So like this?

Definitely simpler codebase that way...

pippinsplugins commented 9 years ago

Yeah, I like that a lot

evertiro commented 9 years ago

Well it's committed!

evertiro commented 9 years ago

Just to clarify... the code is committed, not me :wink:

pippinsplugins commented 9 years ago

Merged in and tagged with Needs Testing for further review before we close it.

pippinsplugins commented 9 years ago

@ghost1227 Looks great to me. Closing.