Closed amdrew closed 9 years ago
Or do it like this at least which is much nicer IMO
+1
On Thu, Apr 9, 2015 at 4:37 PM, Andrew Munro notifications@github.com wrote:
Or do it like this at least which is much nicer IMO
[image: screen shot 2015-04-09 at 3 36 32 pm] https://cloud.githubusercontent.com/assets/52581/7076329/3e72afca-dece-11e4-988b-a6a6b6a29f8a.png
— Reply to this email directly or view it on GitHub https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/3339#issuecomment-91349451 .
I really like this.
:+1:
Yes, I personally would lot to remove it from the list table, or make it hidden until a click. We're wasting a ton of space with that column.
Agreed @cklosowski -- even removing the text/style/color attributes would help.
I know I'm not the average user but I know I've never used it. Might be better as a quick plugin or code snippet to add it to the columns for those who tend to use it a lot.
Something like this?
Maybe a "View" link to toggle the input? Similar to the Edit/Browse links above it.
I just copied Andrew's example... but...
Something like this @spencerfinnell?
This is cool, though you could argue a shortcode that displays a purchase link has nothing to do with publishing the content and is unrelated to everything else in that box. Edit: either way, it's better than the shortcode being listed in the table view.
TECHNICALLY you could argue that the shortcode makes it possible to 'publish' the product wherever you want. But... it wasn't my idea to put it there, I just did the implementation. :wink:
Also, there isn't really anywhere it's 'better' suited on that page, and adding a whole new metabox for it is just silly.
@ghost1227 you could, but the purchase_link shortcode doesn't output all the product information. [downloads ids=xx] would make more sense in that context. But I agree that it's likely the best place on that page all things considered.
I think I'd rather see the short code in the pricing meta box, or perhaps the settings box.
So like this?
Definitely simpler codebase that way...
Yeah, I like that a lot
Well it's committed!
Just to clarify... the code is committed, not me :wink:
Merged in and tagged with Needs Testing
for further review before we close it.
@ghost1227 Looks great to me. Closing.
Here's a nice way of showing the shortcode (From GiveWP, see far right). We should consider doing this for EDD and possibly even go as far as removing the shortcode from the main downloads page. Would make it cleaner.