Settings, Reports, Tools admin page need headings

[SeanTOSCD]

Just noticed that the Settings, Reports, and Tools admin pages do not have headings. I believe they should. On some screen sizes, you wouldn't even know where you are in the dashboard unless you were already familiar with the UI.

[pippinsplugins]

I think they used to but we removed them because of the real estate they take up. Not opposed to playing with re-adding them.

[SeanTOSCD]

@ghost1227 I think they should be branded. If the admin page is not directly tied to an EDD custom post type, the verbiage should connect it to EDD. Which means we should look at all of the admin pages, like Customers. Right now, the Extensions page is the only one with a branded heading.

[evertiro]

@SDavisMedia Using full name would make for some LONG titles... using 'EDD' would cause consistency issues. What are you anticipating?

[zackkatz]

Having a horizontal logo doesn't take much space and enforces branding. Here's what I did with IDX+:

[SeanTOSCD]

I do something similar in Volatyl.

I don't think branding with graphics is necessary, though. I think "Easy Digital Downloads Settings" is acceptable. Longer than normal, sure. But I think that just comes with having a long name.

Thoughts? @cklosowski @mindctrl @pippinsplugins

[spencerfinnell]

Agreed just using the full name seems like the best option. Not sure about a logo.

[chriscct7]

The graphics is cool, but if its done, it needs to be done via a helper function where the string for the header is sent in, that way extensions can easily call a helper function to output the page title and graphic on their pages, so if in the future we want to drop the logo or change it, it doesn't break anything

On Sun, Sep 13, 2015 at 9:04 PM, Spencer Finnell notifications@github.com wrote:

Agreed just using the full name seems like the best option. Not sure about a logo.

— Reply to this email directly or view it on GitHub https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/3795#issuecomment-139933719 .

[SeanTOSCD]

To be clear, I'm not in favor of a graphic.

[evertiro]

A significant part of WHY EDD is designed the way it is comes down to maintaining a uniform appearance with WordPress core. Core doesn't use graphics, I can't imagine us doing it either.

[SeanTOSCD]

Agreed.

[spencerfinnell]

@ghost1227 @SDavisMedia Agreed.

[chriscct7]

Fair enough, my point was more of if we did, it needed to be designed in a way that would make it easy to be uniform. That being said at some point we might want to consider helper functions for titles (just in case we change our mind on this in the future or need to do some a11y stuff), for this and also for registering submenu items since we're thinking of splitting those up

On Sun, Sep 13, 2015 at 9:52 PM, Sean Davis notifications@github.com wrote:

Agreed.

— Reply to this email directly or view it on GitHub https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/3795#issuecomment-139939008 .

[evertiro]

@chriscct7 what are you envisioning? I can't think of anything that'd be more efficient than a simple filter... and even that seems excessive for this.

[chriscct7]

Sorry if I didn't make that more clear: If we're not doing icons, then there's no point to a helper on the menu titles.

[pippinsplugins]

While graphics work really well, I agree that they do not jive well with core experience, so :-1: from me on graphics.

[evertiro]

We could do something like this...

[pippinsplugins]

I like that @ghost1227

For small screenshots, we could either hide the title or force it to sit above the tabs.

[evertiro]

I'll adjust the PR.

[evertiro]

@pippinsplugins @SDavisMedia PR updated

[evertiro]

Also added a class to facilitate adjusting it on mobile... feel free to tweak though!

[SeanTOSCD]

Why are we putting the heading beside the tabs? It already has a place to go and it does not take up much real estate... no more than any other heading does. I don't understand what we're doing here.

[pippinsplugins]

I'm fine with either.

[mindctrl]

I'm with Sean. I like headings at top like most/rest of core does.

[spencerfinnell]

Agreed it should be on top, and I think it should be "Easy Digital Downloads - Settings", or just "Settings"

[sunnyratilal]

@SDavisMedia PR ready.

Question about the nav-tab-wrapper though, is that supposed to be a h1?

[SeanTOSCD]

@sunnyratilal Reports and Tools would need this treatment as well.

As for nav-tab-wrapper, I'm almost positive that should be an h2. I've always used h2 in my own projects and I learned how to do it from multiple resources floating around.

[sunnyratilal]

@SDavisMedia Headings added for Tools and Reports and I've changed from h1 to h2.

[SeanTOSCD]

@sunnyratilal sweet sweet! Can we adjust this to 70%? That should finish it off. The responsive font-size for the nav tabs are a bit small on mobile now.

[sunnyratilal]

@SDavisMedia That's all done. Are we good to merge?

[SeanTOSCD]

@sunnyratilal Yessir! :+1:

[sunnyratilal]

Merged!