awesomemotive / easy-digital-downloads

Sell digital downloads through WordPress
https://easydigitaldownloads.com
GNU General Public License v2.0
868 stars 473 forks source link

Download links give permission denied when qTranslate-X #4210

Closed pippinsplugins closed 8 years ago

pippinsplugins commented 8 years ago

We've just had a customer report (and I replicated) that file download links break when the qTranslate-X plugin is activated, or at least causes the links to break when the language parameter is included in the URL.

qTranslate-X is apparently a new version of qTranslate: https://wordpress.org/plugins/qtranslate-x/installation/

We previously fixed this conflict in https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/3635, https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/1365, and https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/164

pippinsplugins commented 8 years ago

@mindctrl Think you could work on this? Fix should be nearly identical to previous fix.

mindctrl commented 8 years ago

@pippinsplugins do you recall which URL option was being used? image

mindctrl commented 8 years ago

Happens on pre-path mode. Does not happen on query mode.

mindctrl commented 8 years ago

I feel dirty, but it works. I didn't see another clean way.

pippinsplugins commented 8 years ago

I'm okay with dirty, even like it sometimes.

@cklosowski any objections to merging?

cklosowski commented 8 years ago

I'm good with this, merging.