EDD core meta boxes - Githubissues

awesomemotive / easy-digital-downloads

Sell digital downloads through WordPress

https://easydigitaldownloads.com

GNU General Public License v2.0

864 stars 475 forks source link

EDD core meta boxes #4781

Open ramiabraham opened 8 years ago

ramiabraham commented 8 years ago

Slated for release/1.9, we're adding a meta box abstraction in AffiliateWP which eases the creation of meta boxes for a variety of use cases.

The main class can be seen here: https://github.com/AffiliateWP/AffiliateWP/blob/issue/1225/includes/admin/class-metabox-base.php

Five examples of extending this can be seen here: https://github.com/AffiliateWP/AffiliateWP/tree/issue/1225/includes/admin/overview/metaboxes

Would be neat for EDD as well :)

@cklosowski @pippinsplugins Where should this go in EDD core? includes/admin ok for the base class, with a require_once directly wherever needed?

ramiabraham commented 8 years ago

Added EDD_Meta_Box_Base class in https://github.com/easydigitaldownloads/easy-digital-downloads/commit/8b79b80724b0a09350c2975c74acca1df386516c
Location is presently includes/admin/class-meta-box-base.php
Opted not to require or include it anywhere until it's determined where meta boxes should be added
Set @since to 2.7 - just my best guess there.
After creating a class extension of EDD_Meta_Box_Base, nonces for closedpostboxes and meta-box-order will need to be added on the page(s) in which the meta box(es) appear, to enable open/close and position state saving. An example: https://github.com/AffiliateWP/AffiliateWP/blob/issue/1225/includes/admin/overview/overview.php#L54-L55

ramiabraham commented 8 years ago

(Added PR https://github.com/easydigitaldownloads/easy-digital-downloads/pull/4784)

pippinsplugins commented 8 years ago

Excellent! I think we can likely put this in 2.7.

Let's do wait to do anything on this until we have it finalized in AffiliateWP so that we can take advantage of any improvements that make it in there between now and the 1.9 release.

ramiabraham commented 8 years ago

Core meta boxes are stable in AffiliateWP 1.9, but would be nice to get some flight time with it so EDD has the advantage of that data. Once everyone feels enough time has passed, lmk and I'll update the EDD base class with the adjustments added since the initial PR.

pippinsplugins commented 8 years ago

:+1:

cklosowski commented 7 years ago

@ramiabraham How are things looking for AffiliateWP here? Any changes to port back into the EDD class?

pippinsplugins commented 7 years ago

They're working really well in AffiliateWP so could definitely port back. I don't think it's a priority for 2.7 so punting to 2.8,