search

awesomemotive / easy-digital-downloads

Sell digital downloads through WordPress
https://easydigitaldownloads.com
GNU General Public License v2.0
865 stars 475 forks source link

Custom display name account page issue #5612

Open arraypress opened 7 years ago

arraypress commented 7 years ago

If a custom user display name is set either via FES (shop name) or elsewhere in WordPress, the name isn't available to select within the EDD account page drop-down but it is shown within the WordPress admin panel as a drop-down option. It would make sense from a store owners perspective to be able to select this name from the account page drop down since it appears to override the existing display name set.

pippinsplugins commented 7 years ago

@davidsherlock I'm not quite sure what you mean. Could you show me a screenshot or two to illustrate it?

arraypress commented 7 years ago

@pippinsplugins, apologies for the delay in getting back to you regarding this. Here are some screenshots for illustration purposes.

Within FES you can set a "Display Name" via a text field (not a select like the typical WordPress or EDD account page), like this:

screenshot 2017-04-26 23 56 24

Once set, the name is shown within WordPress user edit screen (in the admin panel). However if changed back to another display name, the custom entered name is lost (this wasn't performed here).

screenshot 2017-04-26 23 56 41

Within EDD account page, the name isn't displayed or available.

screenshot 2017-04-26 23 56 58

As per this screenshot:

screenshot 2017-04-26 23 57 06

cklosowski commented 7 years ago

Looking at this, I think this is FES doing something a little 'strange'. FES is hard setting the display_name value, which makes it show in the Profile Editor dropdown. If you never set an FES display name, you never see the option either...and I believe if you change the item in admin, you should no longer have it showing in admin either. The only reason it's showing in Admin is that it's hard set and WP Core includes the current one in the dropdown.

In order to do this correctly, We'd need to make the profile editor (EDD) show the current name as well, if it's not selected...however noting that changing it at any time, will actually overwrite it, and no longer show what was previously shown.

I'm curious what @pippinsplugins thinks about this too. Seems like FES is doing something 'wrong' by hard setting the value, since there are no real methods of extending the display name options in WP Core.

pippinsplugins commented 7 years ago

I'm not entirely sure that "hard setting" it is right or wrong as it definitely works and, while not natively supported by WP, it makes sense.

I think we should make EDD show the value.