3.0 - Country-wide tax rates are confusing.

[mintplugins]

Which tax rate gets used in this scenario?

Can we make the UI better for this in any way?

[mintplugins]

It will use the last entered rate (in this case 12%). But that isn't clear at first glance. Perhaps this could be improved upon.

[cklosowski]

This is similar to an issue I already opened about the tax settings responisveness. Maybe close mine as a dip and include responsiveness In this one?

On Sep 27, 2017 7:06 PM, "Phil Johnston" notifications@github.com wrote:

It will use the last entered rate (in this case 12%). But that isn't clear at first glance. Perhaps this could be improved upon.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/easydigitaldownloads/easy-digital-downloads/issues/6037#issuecomment-332680397, or mute the thread https://github.com/notifications/unsubscribe-auth/ABU2LDZYc0RzyjA7622OZ95qIKiuTLVbks5smtTogaJpZM4Pmfiu .

[mintplugins]

@spencerfinnell What are your thoughts on doing something about this alongside https://github.com/easydigitaldownloads/easy-digital-downloads/issues/7109

The same confusion still exists with the current tax system in EDD3. Both of these tax rates are set to "Apply to whole country"

[spencerfinnell]

It should be pretty easy to determine if a country-wide rate exists now and stop the addition of another, and alert the user of its existence and to deactivate and add again if needed.

[mintplugins]

That sounds like a good flow to me

[cklosowski]

I would agree here, however I think we might run into some issues during the migration? What happens if we have two tax rates that are defined both to apply to the whole country...wouldn't we want to 'deactivate' one of them upon migration? If we detect that the country wide tax rate being inserted upon migration will override a previous one, we should deactivate the previous one when we insert this new one (assuming the iteration works in the same order)

I would agree we need some sort of UI to prevent the confusion state.

[spencerfinnell]

@cklosowski Yes, any country-wide rate that's added during migration should be able to safely deactivate any existing country-wide rate as long as the iteration order is correct. Then the 3.0 UI will reflect what has been used in their Checkout accurately, and a new check during rate addition can be added to prevent further duplicates/ensure the UI remains accurate.

[spencerfinnell]

PR #7575 prevents multiple country wide rates from being added via the UI:

Automatic deactivation on migration needs to be addressed separately.

[cklosowski]

@spencerfinnell I’ve created #7602 to handle the migration aspect of this.