Customer with Multiple Email Address can not Edit or Change Existing Email Addresses

[shazahm1]

Bug Report

Expected behavior

When use the [edd_profile_editor] shortcode I expect that a user with multiple email addresses be able to edit existing or add new one.

I had a customer who was not able to change or edit their email address because the had more than one associated with their account.

https://github.com/easydigitaldownloads/easy-digital-downloads/blob/master/templates/shortcode-profile-editor.php#L70-L97

Actual behavior

The shortcode template only allows a customer to choose an existing email address not edit or remove one.

Steps to reproduce the behavior

1) Add a page with the [edd_profile_editor] shortcode. 2) Add a customer with more than one email address. 3) Navigate to the page with the [edd_profile_editor] shortcode.

Information (if a specific version is affected):

PHP Version: 7.3.14

EDD Version (or branch): 2.9.22

WordPress Version: 5.3.2

Any other relevant information: n/a

[cklosowski]

This will likely be something we can easily implement after 3.0 is created. Right now the email addresses, while being stored in customer meta are initially generated from the order data. With 3.0 we'll have a much more verbose email address storage system of a custom table.

By having a custom table we'll have a direct link to what email address is being added/removed/edited instead of ad-hoc searching the customer meta for it.

[cklosowski]

Users already have the ability to 'remove' any additional email addresses, and they can change their primary email address to any additional email addresses, but they cannot add additional ones.

[dgoldak]

Another report of this issue: https://secure.helpscout.net/conversation/2359009410/3303267?folderId=5762528

If you have more than one email address, you can't change the email address. Customers cannot delete additional email addresses either.