Closed pippinsplugins closed 9 years ago
@mps We have a user that wants to sponsor the development of this (I'll cover whatever his sponsorship doesn't). Could we schedule this out for sometime in the coming weeks?
Right now we show current monthly earnings and all time earnings. This would be a 3rd item added or replacing one of those?
A third one.
On Sat, Aug 16, 2014 at 11:37 AM, Matthew Strickland < notifications@github.com> wrote:
Right now we show current monthly earnings and all time earnings. This would be a 3rd item added or replacing one of those?
— Reply to this email directly or view it on GitHub https://github.com/pippinsplugins/EDD-iOS-App/issues/30#issuecomment-52398002 .
what does the JSON look like for this item?
Query: http://yoursite.com/edd-api/stats/?key=<key>&token=<token>&type=<QUERY TYPE>&date=today
Response:
{
"earnings": {
"today": "25.2"
}
}
@pippinsplugins I do not see this response using #34 credentials.
ah I figured this would be returned from the earnings calls. Seems like I need to make two calls to get current month, alltime and today?
Just curious why today was not appended to the previous call that returns those other items?
Right, it's two calls.
We might combine them later (not really sure why we don't). I'll put it on our todo list.
Sounds good.
@mps We have added Today
to the default view for EDD v2.1.6.
@pippinsplugins ok, so safe to remove two calls in favor of the one?
Yeah let's do that. Could you do a simple check? If the today
stat is present in the API response, show it, otherwise don't? That way it will just start working as people update to EDD v2.1.6
Sounds doable
For myself and many others, the earnings for the current day is one of the most important stats. It makes sense that it be displayed on the home page.