awesomemotive / edd-ios

iOS App for Easy Digital Downloads
0 stars 2 forks source link

Increase target on Site Selector #90

Closed sunnyratilal closed 7 years ago

sunnyratilal commented 7 years ago

The first site in the site selector is sometimes hard to select - the touch target area needs to be increased.

sunnyratilal commented 7 years ago

@pippinsplugins I've been unable to replicate this. Is there a specific point of the cell you find causes this issue?

The cells are the standard iOS cells and the same size as the all the cells on the More view.

pippinsplugins commented 7 years ago

It's the entire area but oddly only happens sometimes. When it happens the only way to switch to the top site is to click on the very, very boom sliver of the cell.

mindctrl commented 7 years ago

I've experienced this issue too. Trying to select the first site in the list sometimes results in Add Site dialog coming up instead.

pippinsplugins commented 7 years ago

@sunnyratilal Another way to solve this would be to remove the + in the top right corner and instead add a cell at the bottom of the site list for Add New Site.

sunnyratilal commented 7 years ago

img_0052

@pippinsplugins I've done this so far so it makes the cell larger and also gives it some padding. Beta will be pushed out in a few hours - should we give this a try first?

pippinsplugins commented 7 years ago

That looks good to me. Let's go with that and see if it resolves it.