search

awesomemotive / edd-themedd

WordPress theme for Easy Digital Downloads
https://themedd.com
33 stars 10 forks source link

Download archive page subtitle support #163

Open arraypress opened 6 years ago

arraypress commented 6 years ago

This is merely just an idea and it might be better placed as a code snippet or child theme. With that said I feel it could conditionally work with Themedd core as well, hence opening this for discussion.

I use the popular Subtitles plugin on a lot of my WP sites and it integrates perfectly with Themedd, however since the download archive now has title support, It would be useful if the subtitles plugin was installed to be able to set the subtitle as well as the title from within the customizer. This would help keep congruency across all the pages (categories, tags, pages, posts, etc.) and maintain a unified look throughout the site/theme.

arraypress commented 6 years ago

For sake of clarity, this plugin (this really should be in core WordPress!): https://wordpress.org/plugins/subtitles/

amdrew commented 6 years ago

@davidsherlock To clarify, there would be a new input field shown underneath the new one to set the subtitle. This input field would only be shown if subtitles is installed and activated, and the EDD archive page hasn't been disabled. Is that correct?

This feels like a "nice to have", probably not something I see as being included at this point, unless it is requested a lot. For now, I think it is better as a code snippet or included from the child theme.

arraypress commented 6 years ago

That is correct @amdrew, and I do in part agree this isn’t “essential” per say but certainly useful to have to maintain uniformity across the site.

Sent from my iPhone

On 21 Oct 2017, at 02:10, Andrew Munro notifications@github.com wrote:

@davidsherlock To clarify, there would be a new input field shown underneath the new one to set the subtitle. This input field would only be shown if subtitles is installed and activated, and the EDD archive page hasn't been disabled. Is that correct?

This feels like a "nice to have", probably not something I see as being included at this point, unless it is requested a lot. For now, I think it is better as a code snippet or included from the child theme.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.