awesomemotive / edd-themedd

WordPress theme for Easy Digital Downloads
https://themedd.com
32 stars 9 forks source link

1.1: Conflict with All Access #223

Open SeanTOSCD opened 5 years ago

SeanTOSCD commented 5 years ago

It appears there's a clash with the new themedd_edd_purchase_variable_pricing() function (I believe it's new).

[04-Jan-2019 19:31:30 UTC] PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function edd_all_access_remove_price_amounts(), 5 passed in /app/public/wp-includes/class-wp-hook.php on line 286 and exactly 6 expected in /app/public/wp-content/plugins/edd-all-access/includes/functions/download-form.php:318
Stack trace:
#0 /app/public/wp-includes/class-wp-hook.php(286): edd_all_access_remove_price_amounts('<span class="ed...', 28530, 0, Array, '')
#1 /app/public/wp-includes/plugin.php(203): WP_Hook->apply_filters('<span class="ed...', Array)
#2 /app/public/wp-content/themes/themedd/includes/compatibility/edd/template-functions.php(69): apply_filters('edd_price_optio...', '<span class="ed...', 28530, 0, Array, '')
#3 /app/public/wp-includes/class-wp-hook.php(286): themedd_edd_purchase_variable_pricing(28530, Array)
#4 /app/public/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array)
#5 /app/public/wp-includes/plugin.php(453): WP_Hook->do_action(Array)
#6 /app/public/wp-content/plugins/easy-digital-downloads/includes/templat in /app/public/wp-content/plugins/edd-all-access/includes/functions/download-form.php on line 318

If I remove action the custom function, everything is fine again. The issue shows up where variable price options are output.

I have not looked into any finer details at this point. Just recording the bug for 1.1 development.