search

awesomemotive / edd-themedd

WordPress theme for Easy Digital Downloads
https://themedd.com
32 stars 9 forks source link

Release/1.1 #257

Closed ashleyfae closed 3 years ago

ashleyfae commented 3 years ago

Made this draft PR because EDD Site runs on release/1.1 and I realized I had no idea what was in it and wanted to get an overview.

Milestone: https://github.com/easydigitaldownloads/themedd/milestone/3

robincornett commented 3 years ago

When I go to All Downloads with All Access active, I'm getting this fatal error:

[06-Oct-2021 15:04:25 UTC] PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function edd_all_access_remove_price_amounts(), 5 passed in \wp-includes\class-wp-hook.php on line 303 and exactly 6 expected in \wp-content\plugins\edd-all-access\includes\functions\download-form.php:337

cklosowski commented 3 years ago

We cannot use release/1.1 to make a Themedd release. I can explain more in a conversation but the reality is that release/1.1 went WAY further than it was supposd to and will basically break anyone's site that made a child theme off of Themedd prior to release/1.1.

With all these changes to release/1.1 I'm not even sure I can put it on the EDD site anymore.

This is going to take a bit to unwind and the themes should just be left alone for now until we can make the new release process finalized.