search

awesomemotive / sugarcalendar-core

Sugar Calendar plugin for WordPress
https://wordpress.org/plugins/sugar-calendar-lite/
38 stars 14 forks source link

Gutenberg support #45

Closed herewithme closed 4 years ago

herewithme commented 4 years ago

Do you plan to support Gutenberg block editor on your event post type ?

I create a quick gist for enable it, but, it's really basic, and very little tested. https://gist.github.com/herewithme/f1c377377cc3dcedc8388dd97196fdb6

JJJ commented 4 years ago

Neat Gist; thank you!

We are definitely going to support Gutenberg!

JJJ commented 4 years ago

I'm testing your Gist on WordPress 5.5, and it does not appear to be working.

The meta-box never appears for the sc_event post type, though I can force it to appear in the post type with a little bit of hacking. (In doing so, I discovered some improvements we can make with how we enqueue the related JavaScript and CSS as well.)

Thoughts?

herewithme commented 4 years ago

On WP5.4, with my gist : image

JJJ commented 4 years ago

I'm testing with WordPress 5.5.

jjj-sc-2020-08-02 at 21 58 55@2x

As you can see, the "Event" meta-box does not end up as registered.

Plausible there is a regression, or my local checkout of 5.5 is not built correctly. Able to try 5.5?

JJJ commented 4 years ago

Coming back around to test this again with WordPress 5.5, and I'm seeing the same result.

Any thoughts @herewithme?

JJJ commented 4 years ago

I was able to track this down to some hidden meta-box user options.

Going to test this a bit more.

JJJ commented 4 years ago

Pull request ready for testing. cc @herewithme

JJJ commented 4 years ago

Merged, and released with 2.0.20.

herewithme commented 4 years ago

Thanks @JJJ (sorry for the delay, holidays ;))

JJJ commented 4 years ago

Thank you for the idea, nudge, and proof of concept. It turned out pretty good!