Open m-e-h opened 7 years ago
I don't see any reason we cannot add support for thumbnails.
@pippinsplugins you think in core by default, or with an add-on?
The only reason I ask, is while most calendar applications do allow rich media embedded into events, none that I have researched support a way to give an event a specific unique thumbnail.
We'd need to make some decisions around how far/deep this gets supported, given the block-based future ahead of us, and how Post Types tend to use thumbnails as featured header images, etc...
Will require:
add_post_type_support()
)Image
support (see sugarcalendar/core#47)Personally, I'm leaning towards having this as an add-on, or focusing on Event blocks instead via sugarcalendar/standard#135. Thoughts?
If we build this, I do think it should be in core, but let's hold of on making a decision until later. We can keep an eye open for additional requests.
To add some context to the original issue, I was needing to display the event thumbnails in an events list.
Obviously, this would mostly be up to the theme for thumbnails on archives and single posts, but I was a little surprised to find that there wasn't an option in the Events List widget nor an attribute for the shortcode to do this.
Wasn't a big deal to use the sc_before_event_list_item
hook to do it but thought I'd open this issue in case there were others with the same expectations since thumbnail
was already supported on the sc_event
post type.
To show a "Featured Image" use case, I think it's pretty slick how Google calendar does their event lists:
btw, 2.0 is looking great so far!
Any plans to add a thumbnail option, maybe to the
show
parameter insc_get_events_list()
?The post-type supports thumbnails. Might be nice to display them in the events_list shortcodes and widgets.