awesomized / libmemcached

Resurrection of libmemcached
https://awesomized.github.io/libmemcached/
BSD 3-Clause "New" or "Revised" License
45 stars 26 forks source link

Fix #116 add configure.h for libmemcachedprotocol #117

Closed remicollet closed 3 years ago

remicollet commented 3 years ago

Fedora 35 build:

libmemcached-awesome rebuild using this patch https://koji.fedoraproject.org/koji/taskinfo?taskID=72673042

php-pecl-memcached rebuild using above https://koji.fedoraproject.org/koji/taskinfo?taskID=72673042

codecov-commenter commented 3 years ago

Codecov Report

Merging #117 (4642f94) into v1.x (b73f12a) will decrease coverage by 0%. The diff coverage is n/a.

:exclamation: Current head 4642f94 differs from pull request most recent head 8b3a224. Consider uploading reports for the commit 8b3a224 to get more accurate results Impacted file tree graph

@@          Coverage Diff          @@
##            v1.x    #117   +/-   ##
=====================================
- Coverage     68%     68%   -0%     
=====================================
  Files        192     192           
  Lines      17450   17450           
=====================================
- Hits       11902   11885   -17     
- Misses      5548    5565   +17     
Impacted Files Coverage Δ
src/libmemcached/io.cc 65% <0%> (-5%) :arrow_down:
test/lib/Connection.cpp 79% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73f12a...8b3a224. Read the comment docs.

remicollet commented 3 years ago

@m6w6 ready for review.

m6w6 commented 3 years ago

Thank you!