search

awesomized / libmemcached

Resurrection of libmemcached
https://awesomized.github.io/libmemcached/
BSD 3-Clause "New" or "Revised" License
45 stars 26 forks source link

If libcrypto implementation of AES is used, do not compile internal #122

Closed TomasKorbar closed 3 years ago

TomasKorbar commented 3 years ago

Hi, this is somewhat cosmetic change. When libcrypto implementation of AES is used, rijndael.cc file does not have to be compiled and linked into the library. This allows us to not list rijndael AES implementation as bundled feature of libmemcached in Fedora and RHEL package.

codecov-commenter commented 3 years ago

Codecov Report

Merging #122 (65a1489) into v1.x (6079c0e) will decrease coverage by 8%. The diff coverage is n/a.

:exclamation: Current head 65a1489 differs from pull request most recent head 0dc8017. Consider uploading reports for the commit 0dc8017 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##            v1.x    #122     +/-   ##
=======================================
- Coverage     68%     61%     -8%     
=======================================
  Files        194     194             
  Lines      17478   15978   -1500     
=======================================
- Hits       11929    9704   -2225     
- Misses      5549    6274    +725
Impacted Files Coverage Δ
src/libmemcached/common.h 0% <0%> (-100%) :arrow_down:
src/libmemcached/csl/context.h 0% <0%> (-87%) :arrow_down:
src/libmemcached/memory.h 0% <0%> (-86%) :arrow_down:
test/lib/Server.hpp 0% <0%> (-77%) :arrow_down:
src/libmemcached/auto.cc 0% <0%> (-69%) :arrow_down:
src/libmemcached/options.cc 0% <0%> (-63%) :arrow_down:
src/libmemcached/behavior.cc 12% <0%> (-60%) :arrow_down:
test/lib/random.hpp 40% <0%> (-60%) :arrow_down:
src/libmemcached/namespace.cc 0% <0%> (-58%) :arrow_down:
src/libmemcached/sasl.cc 0% <0%> (-49%) :arrow_down:
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6079c0e...0dc8017. Read the comment docs.