Open m6w6 opened 4 years ago
These headers should be renamed, preferably each to a distinct name.
Due to this, Windows in-tree builds of PECL/memcached fail, because other extensions include these files:
C:\php-snap-build\dep-aux\vs16\x64\libmemcached\include\libhashkit-1.0\string.h(27): error C2054: expected '(' to follow 'HASHKIT_API' (compiling source file ext\bz2\bz2.c)
…
Yeah, libmemcached/include/libhashkit-1.0
and siblings must not be in the include paths
And that is even possible. Thanks!
Imported from Launchpad using lp2gh.
$ find . -name string.h ./third_party/libmemcached/libmemcached-1.0/struct/string.h ./third_party/libmemcached/libhashkit-1.0/string.h ./third_party/libmemcached/libhashkit/string.h ./third_party/libmemcached/tests/string.h
"string.h" is a header from the C runtime library. Project headers should not use this name.