headers with a standard name like `string.h` and `limits.h` should be renamed

awesomized / libmemcached

Resurrection of libmemcached

https://awesomized.github.io/libmemcached/

BSD 3-Clause "New" or "Revised" License

45 stars 26 forks source link

headers with a standard name like `string.h` and `limits.h` should be renamed #61

Open m6w6 opened 4 years ago

m6w6 commented 4 years ago

Reported as: lp:1436744
Reported by: lp:~grobbelaar
Reported at: 2015-03-26T08:52:21Z

Imported from Launchpad using lp2gh.

$ find . -name string.h ./third_party/libmemcached/libmemcached-1.0/struct/string.h ./third_party/libmemcached/libhashkit-1.0/string.h ./third_party/libmemcached/libhashkit/string.h ./third_party/libmemcached/tests/string.h

"string.h" is a header from the C runtime library. Project headers should not use this name.

m6w6 commented 4 years ago

Comment by: lp:~grobbelaar:
Created at: 2015-03-26T08:53:31Z

These headers should be renamed, preferably each to a distinct name.

cmb69 commented 2 years ago

Due to this, Windows in-tree builds of PECL/memcached fail, because other extensions include these files:

C:\php-snap-build\dep-aux\vs16\x64\libmemcached\include\libhashkit-1.0\string.h(27): error C2054: expected '(' to follow 'HASHKIT_API' (compiling source file ext\bz2\bz2.c)
…

m6w6 commented 2 years ago

Yeah, libmemcached/include/libhashkit-1.0 and siblings must not be in the include paths

cmb69 commented 2 years ago

And that is even possible. Thanks!