search

awestlake87 / pyo3-asyncio

Other
300 stars 45 forks source link

Bump and migrate pyo3 to 0.21 #121

Open jopemachine opened 5 months ago

jopemachine commented 5 months ago

Thank you for contributing to pyo3-asyncio!

Please consider adding the following to your pull request:

Be aware the CI pipeline will check your pull request for the following:

Fixes #119.

Ref: https://pyo3.rs/v0.21.0/migration.html

I've updated pyo3-asyncio code referring to the migration guide. I'd appreciate it if you could let me know if there's anything I've missed.

MeepoWin commented 4 months ago

Any progress of this? It sort of block our migration.

cjdsellers commented 4 months ago

@awestlake87 Are there any subtasks here you need a hand with?

cjdsellers commented 4 months ago

@jopemachine I think the changes for behavior (American English) -> behaviour (British English) is another case of words which aren't actually typos, we might want to revert those too to make the PR easier to review?

jopemachine commented 4 months ago

@jopemachine I think the changes for behavior (American English) -> behaviour (British English) is another case of words which aren't actually typos, we might want to revert those too to make the PR easier to review?

It is already reverted in df5f892 (Reverted words misunderstood as typo)

cjdsellers commented 4 months ago

I'm still seeing changes at the head of this branch for Code-of-Conduct.md though?

I must be misunderstanding - this PR is also reverting previous changes which were considered typos I'm assuming.

kdmkone commented 3 months ago

Hi! Is there anything we can do to help port this over? We're currently blocked in migrating to a newer PyO3 version for this.

davidhewitt commented 2 months ago

As per https://github.com/awestlake87/pyo3-asyncio/issues/119#issuecomment-2166720029

While waiting for a permanent decision on what to do, I've published https://crates.io/crates/pyo3-asyncio-0-21 from a fork at https://github.com/davidhewitt/pyo3-asyncio