search

awestlake87 / pyo3-asyncio

Other
300 stars 45 forks source link

feat: Initialize the Tokio runtime with a custom Tokio runtime #83

Closed rise0chen closed 1 year ago

rise0chen commented 1 year ago

Initialize the Tokio runtime with a custom Tokio runtime

awestlake87 commented 1 year ago

Looks good to me, although this might have to wait for pyo3 v0.18 unless there's a good reason to release it earlier. I'm still open to it, so feel free to push for a patch release if you want it.

rise0chen commented 1 year ago

TokioRT is an alias of tokio::runtime::Runtime. I changed it back

awestlake87 commented 1 year ago

TokioRT is an alias of tokio::runtime::Runtime. I changed it back

Oh my bad, you're right. For some reason I thought that was your enum. I think it's fine as a patch. I'll probably add a test for it before releasing it though.

awestlake87 commented 1 year ago

Hey, I went ahead and merged this into the 0.18 release today. Sorry it's been just sitting here for so long!