search

awesto / django-shop

A Django based shop system
http://www.django-shop.org
BSD 3-Clause "New" or "Revised" License
3.19k stars 1.04k forks source link

Tutorial demo needs djangoshop-stripe #698

Open mortlind opened 6 years ago

mortlind commented 6 years ago

When following the tutorial demo, I found a missing dependency on djangoshop-stripe. Being a newcomer, I installed django-shop-stripe, which led to further problems, until sombody was kind and guided me to the correct djangoshop-stripe. The tutorial requirements.txt should depend on djangoshop-stripe or at least $ pip install djangoshop-stripe should be mentioned in the tutorial.

jrief commented 6 years ago

The requirements.txt in example does indeed depend on djangoshop-stripe. Django-SHOP itself doesn't depend on Stripe. The framework shall (for good reasons) not depend on any PSP.

mortlind commented 6 years ago

@jrief I find django-stripe in requirements/text.txt, but that file is not mentioned in the tutorial, only requirements/common.txt. I understand that django and django-shop itself should not depend on any PSP.

mortlind commented 6 years ago

@jrief If in doubt, and if you have time, could you please perform the tutorial [1] up to, and including (shoptutorial)$ ./manage.py migrate? It will be very interesting to understand how this issue would not arise for you ...

[1] http://django-shop.readthedocs.io/en/latest/tutorial/intro.html

jrief commented 6 years ago

yes, have to rework on the tutorial

Aiky30 commented 6 years ago

@rfleschenberg @jrief A similar issue was raised regarding confusion about the requirements file. It was discussed that the tutorial doesn't mention the Django specific requirements files and just states common.txt which doesn't include Django angular and select 2. This is slightly unrelated to the stripe dependency but is related to reworking the tutorial docs. Better to record it here so it isn't lost.

https://github.com/awesto/django-shop/issues/713

tretaki commented 6 years ago

Agree with @mortlind had the same problem. djangoshop-stripe saved the problem. Thanks for the solution @mortlind