search

awesto / django-shop

A Django based shop system
http://www.django-shop.org
BSD 3-Clause "New" or "Revised" License
3.17k stars 1.04k forks source link

Wrong usage of Compressor constructor #794

Open elipavlov opened 4 years ago

elipavlov commented 4 years ago

Hi there.

Recently i've tried to generate demo instance of django-shop from cookiecutter template.

It was generated successfully. But when i've tried to up services, web application started throwing errors.

So, i've tried to research problem and if I understood correctly, usage of Compressor constructor implies to pass positional resource_kind arg.

Seems the problem was added here: https://github.com/awesto/django-shop/commit/807c7c5d1797cb6353795223927cb9dfd0c849e7#diff-59d012f061f377c7836bdb130f0a5ad4R25

Here you can see Compressor constructor, if i figured out it correct: https://github.com/django-compressor/django-compressor/blame/2.4/compressor/base.py#L35

Seems this issue reproduced in certain cookiecutter configuration - with uwsgi server which a was select.

haricot commented 4 years ago

Hi @elipavlov,

possible related : https://github.com/awesto/cookiecutter-django-shop/pull/21 Otherwise what is the error output ?

jrief commented 4 years ago

Thanks for reporting. Actually, this special Sekizai compressor has been introduced recently into django-compressor, so there is no need to configure it through django-shop. I will fix this in the cookiecutter template.