search

awesto / django-shop

A Django based shop system
http://www.django-shop.org
BSD 3-Clause "New" or "Revised" License
3.17k stars 1.04k forks source link

Fix bug with ipware.ip import get_ip #825

Closed xggrnx closed 4 years ago

xggrnx commented 4 years ago

In https://github.com/awesto/django-shop/blob/master/setup.py 'django-ipware', but in https://github.com/awesto/django-shop/blob/master/tests/requirements.txt django-ipware==2.1.0

with ipware > 2.1.0 have an error.

jrief commented 4 years ago

Thanks. The next time please also provide a line or two for the Changelog file.

xggrnx commented 4 years ago

Ok, just my first bug fix in opensource product. Ty.

SergeyMatsiupa commented 3 years ago

hmm... looks like this fix isn't included yet into official installation model (https://django-shop.readthedocs.io/en/1.2.2/tutorial/intro.html)

jrief commented 3 years ago

You changes have been released in version 1.2.3. Thanks again.