search

awesto / django-shop

A Django based shop system
http://www.django-shop.org
BSD 3-Clause "New" or "Revised" License
3.17k stars 1.04k forks source link

Fixed missing phone number in Django Shop Plugin #863

Open shivamraj74 opened 2 years ago

shivamraj74 commented 2 years ago

Missing phone number option in link plugin #861 Django Shop plugin is missing due to overriding the LinkForm.LINK_TYPE_CHOICES property. By letting add to LinkForm if the phone number exists.

execut commented 2 years ago

@shivamraj74 I already fixed it bug here #862. I think my solution is more correct since it eliminates duplication of the parent's code.

shivamraj74 commented 2 years ago

I think simply eliminating the parent's code, could not arise security issues?

execut commented 2 years ago

I think simply eliminating the parent's code, could not arise security issues?

I don't quite understand how this can cause security problems. Please, show me an example.

shivamraj74 commented 2 years ago

Well, it was missing due to overriding of class LinkForm property, so I basically corrected at cascade plugin and now let the owner decide it.