search

awestruct / web-editor

A web based editor for awestruct projects
8 stars 6 forks source link

Add the ability to upload & insert images #13

Closed pmuir closed 11 years ago

pmuir commented 11 years ago

Perhaps some special handling for images? Images are odd, in that people really want to insert them "inline" most of the time. Wondering if we could have an upload&insert dialog?

pmuir commented 11 years ago

I like what github does - drag and drop, and paste from clipboard.

wesbos commented 11 years ago

@LightGuard Should images be added to the repo?

mojavelinux commented 11 years ago

+1 to the GitHub approach. I know a few not as technical folks who report being very successful using that feature.

LightGuard commented 11 years ago

Yes, images should be added to the repo — Sent from Mailbox for iPhone

On Tue, Jun 25, 2013 at 11:34 AM, Dan Allen notifications@github.com wrote:

+1 to the GitHub approach. I know a few not as technical folks who report

being very successful using that feature.

Reply to this email directly or view it on GitHub: https://github.com/awestruct/web-editor/issues/13#issuecomment-19993249

wesbos commented 11 years ago

@LightGuard will the API support a POST of uploading a file?

LightGuard commented 11 years ago

Haven't tried binary yet — Sent from Mailbox for iPhone

On Tue, Jul 2, 2013 at 10:29 AM, Wes Bos notifications@github.com wrote:

@LightGuard will the API support a POST of uploading a file?

Reply to this email directly or view it on GitHub: https://github.com/awestruct/web-editor/issues/13#issuecomment-20357562

wesbos commented 11 years ago

We also need to decide on where to put the images. Should this be a site-wide setting? Or ask them each time they upload an image?

LightGuard commented 11 years ago

I'd actually prefer to ask. We could default to images in the field already (less to fill out).

On Tue, Jul 2, 2013 at 8:18 PM, Wes Bos notifications@github.com wrote:

We also need to decide on where to put the images. Should this be a site-wide setting? Or ask them each time they upload an image?

— Reply to this email directly or view it on GitHubhttps://github.com/awestruct/web-editor/issues/13#issuecomment-20391788 .

Jason Porter http://en.gravatar.com/lightguardjp

pmuir commented 11 years ago

Version 1 will need to support not asking, and using a site-wide setting. In fact, I'm struggling to know when you would want to ask, given the target audience is non-technical people.

So I would suggest a site-wide config for version 1, and then if we get a feature request for adding asking, we could add it.

LightGuard commented 11 years ago

Sub directories immediately come to mind.  — Sent from Mailbox for iPhone

On Wed, Jul 3, 2013 at 6:43 AM, Pete Muir notifications@github.com wrote:

Version 1 will need to support not asking, and using a site-wide setting. In fact, I'm struggling to know when you would want to ask, given the target audience is non-technical people.

So I would suggest a site-wide config for version 1, and then if we get a feature request for adding asking, we could add it.

Reply to this email directly or view it on GitHub: https://github.com/awestruct/web-editor/issues/13#issuecomment-20412643

pmuir commented 11 years ago

Putting the image in a sub-directory? I'm not sure that the target audience is going to understand why and when they would want to do this...

LightGuard commented 11 years ago

Just to keep things organized. All images related to x go here, y goes there. Might not though. We can keep it at images for v1.  — Sent from Mailbox for iPhone

On Wed, Jul 3, 2013 at 7:39 AM, Pete Muir notifications@github.com wrote:

Putting the image in a sub-directory? I'm not sure that the target audience is going to understand why and when they would want to do this...

Reply to this email directly or view it on GitHub: https://github.com/awestruct/web-editor/issues/13#issuecomment-20415661

pmuir commented 11 years ago

I'm really not sure our target audience will care about things like that.

Also, I've not normally seen images sorted like that. What I think is more common is to see things arranged by type e.g. glyphicons, branding etc.

If we allow this to be configured site wide, we can always set it to something like images/authors or something, to keep them out of the way of the more structured image sets.

wesbos commented 11 years ago

Image uploads with file select or drag/drop upload are working great ATM. Going to close this one, if we want to create a custom image uploads path in the future we can reopen/create a new issue.