search

awestruct / web-editor

A web based editor for awestruct projects
8 stars 6 forks source link

Token Auth #63

Closed wesbos closed 11 years ago

wesbos commented 11 years ago

I have the token auth in place right now. When the page loads the following should be checked:

  1. Check for a token
  2. If no token, ask to auth with github
  3. if a token, try to grab /settings
  4. If no settings, setup the repo (clone and brand)

You will see that right now, visiting /token in another browser or incognito mode will still deliver a token. This should only happen if we have a session cookie or are doing it over basic auth.

LightGuard commented 11 years ago

Looking good. Should we clean up any commented out / dead code before we merge?

wesbos commented 11 years ago

Yeah, I'll give it a clean up yet. I have 1 more question for you.

On Thursday, August 29, 2013, Jason Porter wrote:

Looking good. Should we clean up any commented out / dead code before we merge?

— Reply to this email directly or view it on GitHubhttps://github.com/awestruct/web-editor/pull/63#issuecomment-23469363 .

Wes Bos Web Development & Design http://www.WesBos.com http://www.WesBos.com Skype: wes.bos Phone: 416 833 3641

LightGuard commented 11 years ago

What's the question?

On Thu, Aug 29, 2013 at 6:51 AM, Wes Bos notifications@github.com wrote:

Yeah, I'll give it a clean up yet. I have 1 more question for you.

On Thursday, August 29, 2013, Jason Porter wrote:

Looking good. Should we clean up any commented out / dead code before we merge?

— Reply to this email directly or view it on GitHub< https://github.com/awestruct/web-editor/pull/63#issuecomment-23469363> .

Wes Bos Web Development & Design http://www.WesBos.com http://www.WesBos.com Skype: wes.bos Phone: 416 833 3641

— Reply to this email directly or view it on GitHubhttps://github.com/awestruct/web-editor/pull/63#issuecomment-23486462 .

Jason Porter http://en.gravatar.com/lightguardjp

wesbos commented 11 years ago

When I PUT to /settings I get the following 500 error and I'm not able to clone the repo:

bad argument (expected URI object or URI string)

Pretty sure it has to do with the URI() method

LightGuard commented 11 years ago

What are you inputting?

On Thu, Aug 29, 2013 at 7:07 AM, Wes Bos notifications@github.com wrote:

When I PUT to /settings I get the following 500 error and I'm not able to clone the repo:

bad argument (expected URI object or URI string)

Pretty sure it has to do with the URI() method

— Reply to this email directly or view it on GitHubhttps://github.com/awestruct/web-editor/pull/63#issuecomment-23487437 .

Jason Porter http://en.gravatar.com/lightguardjp