awgil / ffxiv_bossmod

BossMod FFXIV dalamud plugin
BSD 3-Clause "New" or "Revised" License
244 stars 94 forks source link

Make options toggleable #16

Closed abranon closed 1 year ago

abranon commented 2 years ago

Rewording for clarity

awgil commented 2 years ago

Can you clarify what exactly do you propose?

Currently option is toggleable via config (and, since it's disabled by default, I assume that you've found it and enabled it - and thus are asking for some other toggle).

BTW personally i'm not 100% happy with current implementation, so really open to ideas for improvement. As a workaround, if I really need to cancel cast and move asap, I use LMB+RMB movement (this works, since current implementation works on WSAD keypress level).

abranon commented 2 years ago

I do think that a toggle option might still be beneficial, adding the toggle command to a slash command makes it easy to add it to your in-game macros and essentially make a button that lets you cancel the movement locks until you turn it back on.

abranon commented 2 years ago

Also something else I've noticed playing WHM is that ticking on the smart queue system and using Asylum, Liturgy or Aquaveil (not sure if more but can check) ignores the input and behaves as if I'm casting glare. So what I click is Glare > Dia > Glare > POM > Glare > Asylum What instead happens is Glare > Dia > Glare > POM > Glare > Glare > Glare > Dia > Asylum

awgil commented 2 years ago

Slash command should be simple to implement.

Re. ogcds not casting - current logic only considers casting ogcds if it won't delay next gcd. Under POM this window is quite small (~0.5s, less if you have lag) - if you don't hit your glare button in this window, ogcd won't be cast (since that would delay gcds). I think I need to add some option that allows delaying GCDs by some small configurable amount for WHM (and in future for other healers and/or casters?), since getting that ogcd off is really much more important for a healer than maximizing gcd uptime...

awgil commented 2 years ago

Added console commands to toggle various config options. Try "/vbm cfg" (it will show help messages, from there it should be straightforward).

abranon commented 2 years ago

Sorry for the late reply, I got to mess with it a bit this weekend to see how it works and I think I'd need an example or list of what are valid responses. I tried true and false which don't give any indication of it toggling but also doesn't say it's failed; and on/off which gives me a an error that its not valid so that's good

awgil commented 2 years ago

For example: /vbm cfg Autorotation PreventMov false

abranon commented 2 years ago

Works exactly how I expected, thanks!

awgil commented 2 years ago

Note to self: not closing this issue, since there's still unresolved feature request here about tight ogcd windows under things like POM

abranon commented 2 years ago

Another issue came up with the update, previously I was able to use the movement and potion options in autorotation without ticking "Enable autorotation" as it would interact poorly with POM/clipping, now it's mandatory I presume?