Added GNB Lv40, Lv50, L60, L70 support - Githubissues

awgil / ffxiv_bossmod

BossMod FFXIV dalamud plugin

BSD 3-Clause "New" or "Revised" License

232 stars 76 forks source link

Added GNB Lv40, Lv50, L60, L70 support #362

Closed Akechi-kun closed 1 month ago

Akechi-kun commented 1 month ago

There were certain bugs within the code that were causing Autorotation to brick in plenty of instances regarding Lv40-Lv72.

This is a fix for that.

I added support for lower levels, preferably Lv40-70

Lv40: Added logic to make sure ST and AOE combo works effectively the same as Lv50 combo.
Lv50: Added logic to ensure the appropriate skills are being used for the correct rotation. No Mercy was not being procced on ST or AOE & when you used it manually, it would get stuck. Added a couple !state checks to ensure no funny business with locked skills due to level sync. (fuck off Gnashing Fang)
Lv60: Fixed AOE combo issue; Kept getting stuck on Fated Circle, so added a !state check for appropriate skills to ensure Burst Strike (or Gnashing Fang) is used, regardless of ST or AOE.
Lv70: basically same shit as Lv60.

Akechi-kun commented 1 month ago

I'm not sure why these keep failing the build checks, as I am only within GNBRotation.cs, however if there's something I am missing within the framework please lmk.

CarnifexOptimus commented 1 month ago

I'm not sure why these keep failing the build checks, as I am only within GNBRotation.cs, however if there's something I am missing within the framework please lmk.

you can click on the details of the failed check to see which changes need to be made