awhb / pe

0 stars 0 forks source link

Some valid names considered inappropriate #2

Open awhb opened 12 months ago

awhb commented 12 months ago

Screenshot 2023-11-17 at 4.24.22 PM.png

Names are considered inappropriate if not comprising alphanumeric characters and spaces.

Screenshot 2023-11-17 at 4.27.31 PM.png

However, sample data contains an individual with such an inappropriate name.

Screenshot 2023-11-17 at 4.24.22 PM.png

Trying to add someone with similar name (intuitively valid) also leads to warning on inappropriateness. Hence users can be inconvenienced by warnings of a name being inappropriate even though the name should not be considered as such.

nus-pe-bot commented 11 months ago

Team's Response

Hi thanks for the report! I am the dev that implemented the warning system and am hence responsible. I don't think this is an issue. Ultimately there are so many possible names (chinese characters, cyrillic script, so on) that we cannot provide a strict validity check on all names. The warning system is meant to inform the user in case they have made an unintentional mistake, however if it was intended the user can just choose to ignore it. I don't think that users would be inconvenienced either since the warning doesn't actually prevent them from doing anything. Hence I've chosen to reject this issue, but let us know if you still think this is a problem.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that it is unfeasible to provide a strict validity check on all names. However, my point is that providing warnings on appropriateness of names should have considered reasonable varieties of name examples, especially those in the sample data. As the warning messages themselves do not indicate whether the contact was successfully created in the end or what name the contact was created with even, users are inconvenienced by this implementation of name appropriateness checking, hence I believe it is a functionality bug in my opinion.