search

awhb / pe

0 stars 0 forks source link

bsort accepts invalid sorting order #4

Open awhb opened 10 months ago

awhb commented 10 months ago

Screenshot 2023-11-17 at 4.33.13 PM.png

Documentation mentions directions that are not a or d are invalid.

however, running bsort t/c works: Screenshot 2023-11-17 at 4.35.08 PM.png

nus-pe-script commented 10 months ago

Team's Response

bsort t/c still works because the direction (that is invalid being c) follows an invalid prefix t/, and is ignored by the sort command as mentioned in the UG. bsort t/c is equivalent to bsort. This was found in the PE dry run, but however, due to the feature freeze, it was unable to be handled and the UG and DG has mentioned this specific case. Also, running the same command but with a valid prefix and invalid sort order like bsort n/c will not be accepted in the application, and an error will be thrown.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]