search

awhipp / evetrade

Frontend UI for the popular EVE Online market tool
https://evetrade.space
Apache License 2.0
79 stars 23 forks source link

Footer covering search button #190

Closed ree17017 closed 2 years ago

ree17017 commented 2 years ago

Describe the bug When doing a Station to Station or Region to Region search the footer covers the search button

To Reproduce Steps to reproduce the behavior:

  1. Go to https://evetrade.space/?trade=s2s or https://evetrade.space/?trade=r2r
  2. Try to click on search

Expected behavior Be able to click on the search button

Screenshots image

Desktop (please complete the following information):

awhipp commented 2 years ago

@ree17017 Thanks for bringing this to my attention. Unfortunately, I will not be able to fix this as I am completely overhauling the UI. I am hoping to have the deployment complete by the end of the month which should address this bug. In the meantime, it looks like you are using Brave (which I do not test against), can you try another browser in the meantime?

You can track the progress here: https://feature-7-0-api-overhaul--evetrade.netlify.app/

ree17017 commented 2 years ago

Thanks, I will wait until the overhaul is done.

Side note: I tested this in chrome and I see the same issue.

awhipp commented 2 years ago

@ree17017 Very interesting. Tried across my 3 computers (different resolutions) and I cannot replicate.

Can you provide me what resolution you are using? I'll see if I can replicate on my machine to ensure it doesn't happen with the overhaul.

ree17017 commented 2 years ago

Display Resolution: 1920 X 1080 Page Zoom is 100%

You have a position of absolute on your footer. Change it to relative and that fixed it.

I could create a PR if you would like.

awhipp commented 2 years ago

@ree17017 good catch. I haven't updated the css in two years. I'll create a hot fix tomorrow and resolve this. I always assumed it was relative based on how the UI looks on my end. It's been a while. Apologies. :)

awhipp commented 2 years ago

@ree17017 Created a quick bugfix. Can you review this preview build and see if it resolves it from your perspective?

Just making sure since I cannot replicate locally on any machine.

Build: https://bugfix-footer-covering-search--evetrade.netlify.app/

Edit: Merging into dev and then master. Just let me know if the problem persists with the new style changes.

ree17017 commented 2 years ago

Tested and looks great! Thank you for fixing this so quickly! ❤️