search

awhitford / lombok.maven

Maven Plugin for Project Lombok
http://projectlombok.org/
MIT License
110 stars 36 forks source link

Plugin should not log "Skipping Delombok" with WARN level #155

Open nils-christian opened 1 year ago

nils-christian commented 1 year ago

Hi,

In our Maven configuration we usually have some kind of quick build profile, which is executed with Maven's quiet flag. This allows our developers to build the whole project as quickly as possible. As we use the Lombok Maven plugin only as a JavaDoc "preprocessor", we skip it as well.

Howver, we noticed that the Plugin logs a WARN message during these builds.

[WARN] Skipping Delombok

As far as I can tell, this is unusual and I don't know of any other plugins doing that. Take a look at the Maven JavaDoc plugin for instance (https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java). The skipping is logged, but only on INFO level:

if ( skip )
{
  getLog().info( "Skipping javadoc generation" );
  return;
}

I think it would be sufficient if the Lombok plugin would only log on INFO as well.

Thank you and best regards

Nils

nils-christian commented 1 year ago

Hi,

I added a PR for this issue: #156

lprimak commented 1 year ago

@awhitford Bump. Also, line 203 should be also changed to info. If there are no sources, no warning should be issued. Thank you and thanks for the great work!

lprimak commented 1 year ago

@awhitford Would a PR be easier? This looks trivial and is still an issue. Thank you!

lprimak commented 1 year ago

@awhitford Any update on that line 203 issue? I would like to make that change and release the new plugin version so these issues are fixed. Thank you!

pzygielo commented 1 year ago

It would be great to see that warning gone in any way indeed.