search

awhitford / lombok.maven

Maven Plugin for Project Lombok
http://projectlombok.org/
MIT License
110 stars 36 forks source link

[#155] Plugin should not log "Skipping Delombok" with WARN level #156

Closed nils-christian closed 1 year ago

nils-christian commented 1 year ago

Signed-off-by: Nils Christian Ehmke nils-christian.ehmke@bmiag.de

lprimak commented 1 year ago

Upvoted. Need to change line 203 for the same reason as well

pzygielo commented 1 year ago

I would like to see that and 203 line changed as well.

awhitford commented 1 year ago

I would like to see that and 203 line changed as well.

@pzygielo Why would you like this change on line 203? I think my rationale was something along the lines of, "Why would someone add the lombok-maven-plugin without a sourceDirectory? (They must have configured something wrong, so let's warn them.)"

lprimak commented 1 year ago

@awhitford Let's say you have a multi-module project. Some modules have java sources, some don't. Parent POM wants to declare lombok once (so no duplication is present in the POM file) i.e. DRY principle. Currently, the modules with no source code will issue a WARN, which is not desired.

Thank you!

pzygielo commented 1 year ago

Let's say you have a multi-module project.

Yes, that!

For example maven-compiler-plugin ran against <packaging>pom</packaging> project:

[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-compiler-plugin:3.11.0:compile (default-cli) @ project ---
[INFO] No sources to compile
[INFO] ------------------------------------------------------------------------

No warning there.