Use the same scm.url in children as in parent

awhitford / lombok.maven

Maven Plugin for Project Lombok

http://projectlombok.org/

MIT License

111 stars 35 forks source link

Use the same scm.url in children as in parent #33

Closed pzygielo closed 5 years ago

pzygielo commented 5 years ago

Addresses https://github.com/awhitford/lombok.maven/pull/31#issuecomment-491140603

pzygielo commented 5 years ago

I built [other] project with current plugin (i.e. 1.18.8.1-SNAPSHOT) and maven 3.3.9, and it seems it's ok for parent of plugin to have this new attribute in scm element, no issue here. As for this PR, please close if deployment to OSS/central completes successfully or review and consider changes otherwise.

pzygielo commented 5 years ago

I see there is some progress with NEXUS-19912 (thanks for driving it). Thus most probably these changes won't be necessary after all. Closing for now, and keeping fingers crossed.