search

awhitford / lombok.maven

Maven Plugin for Project Lombok
http://projectlombok.org/
MIT License
110 stars 36 forks source link

Fix for issue 18 #36

Closed pdinc-oss closed 3 years ago

pdinc-oss commented 5 years ago

see: https://github.com/awhitford/lombok.maven/issues/18

GigabyteProductions commented 5 years ago

Regarding CI: See #38

pdinc-oss commented 5 years ago

any updates?

pzygielo commented 5 years ago

any updates?

I see some modifications on master were done to fix CI, yet your PR was not updated, and was not successfully processed by Travis. Perhaps you could rebase @jpyeron's commit or merge master in.

pdinc-oss commented 5 years ago

The pull request is for https://github.com/awhitford/lombok.maven/commit/442905ce89ddc2ad7a4812ba267d4f4d6d12c36a

nothing to do with the CI related pushes on a different branch (which are to mitigate a Jenkins issue)

Thank you.

pdinc-oss commented 5 years ago

The PR has been updated to f1344b8ed1f3e45cba925f1f047280eb0518173e, which merges 442905ce89ddc2ad7a4812ba267d4f4d6d12c36a. Please ignore the NON-master branches.

awhitford commented 5 years ago

Rather than adding removeSourceDirectory functionality, why not simply specify false for addOutputDirectory? Would that not solve whatever your problem is?

awhitford commented 3 years ago

Unclear on why this is necessary, so closing it.

pdinc-oss commented 3 years ago

Seems the 2019 comment went to spam. Will provide the test scenario.