search

awickham10 / psdpa

PowerShell module for the Solarwinds DPA REST API
MIT License
8 stars 0 forks source link

Fix Add-DpaAnnotation #18

Closed awickham10 closed 5 years ago

awickham10 commented 5 years ago

Add-DpaAnnotation wasn't working for Azure SQL DB because there wasn't an Azure SQL DB Monitor class. Added the monitor class plus added a some actual integration tests that run against a DPA instance in Azure.

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will increase coverage by 5.31%. The diff coverage is 60.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   68.69%   74.01%   +5.31%     
==========================================
  Files          17       17              
  Lines         246      254       +8     
==========================================
+ Hits          169      188      +19     
+ Misses         77       66      -11
Impacted Files Coverage Δ
PSDPA/Classes/Annotation.ps1 75% <ø> (ø) :arrow_up:
PSDPA/Classes/Monitor.ps1 75% <0%> (-2.42%) :arrow_down:
PSDPA/Public/New-DpaMonitor.ps1 0% <0%> (ø) :arrow_up:
PSDPA/Public/Set-DpaConfig.ps1 0% <0%> (ø) :arrow_up:
PSDPA/Public/Stop-DpaMonitor.ps1 90% <100%> (ø) :arrow_up:
PSDPA/Classes/AccessToken.ps1 100% <100%> (ø) :arrow_up:
PSDPA/Private/Get-DpaAccessToken.ps1 100% <100%> (ø) :arrow_up:
PSDPA/Private/Invoke-DpaRequest.ps1 100% <100%> (+4.16%) :arrow_up:
PSDPA/Public/Get-DpaConfig.ps1 100% <100%> (ø) :arrow_up:
PSDPA/Public/Get-DpaMonitor.ps1 94.11% <100%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9125ce1...b0367dd. Read the comment docs.