Closed bazz1tv closed 9 years ago
If you'd like, I have already manually merged the Mandatory branch and this one into my master branch.. I could create a new pull request from my master and I think it would be easier for you to merge. It's not too hard to do separately though (at least from my local git, not sure about thru a pull request).
bsnes already supports user-redefinable hotkeys for loading ROMs, resetting the emulator, loading/saving states and various other functions. I'd rather continue to add hotkey functionality using that mechanism than add a bunch of hardcoded keys (though I suppose hardcoded keys is more "Mac-ish"...)
In particular, having the Escape key as an "exit" hotkey with a context of the entire application strikes me as dangerous and undesirable. Do you really think it's a good idea if pressing Escape while any debugger subwindow has input focus instantly exits the entire emulator?
how about we forego that then.. i have no problem keeping my fork im happy with it. ^.^
On Fri, Jul 17, 2015 at 5:37 AM, Alex W. Jackson notifications@github.com wrote:
bsnes already supports user-redefinable hotkeys for loading ROMs, resetting the emulator, loading/saving states and various other functions. I'd rather continue to add hotkey functionality using that mechanism than add a bunch of hardcoded keys (though I suppose hardcoded keys is more "Mac-ish"...)
In particular, having the Escape key as an "exit" hotkey with a context of the entire application strikes me as dangerous and undesirable. Do you really think it's a good idea if pressing Escape while any debugger subwindow has input focus instantly exits the entire emulator?
— Reply to this email directly or view it on GitHub https://github.com/awjackson/bsnes-classic/pull/3#issuecomment-122229603 .
Michael Bazzinotti University of Massachusetts Boston bazz@cs.umb.edu http://www.bazz1.com
OK I took a look. Actually, only the Load Cartridge and Reset shortcuts are available in the bsnes configuration menu. All of the other shortcuts I manually hard-coded are not customizable in the program. However, I agree that by instead adding the new shortcuts as additions to the customize-able system would be cooler.
BTW, I personally love the idea of hitting escape to easily quit out.. and that's my choice.. I can learn to add these hotkeys as optional features rather than hard coded things tho.
OK I have implemented additional keyboard customization shortcuts.. The gist of it can be seen here: https://github.com/bazzinotti/bazzsnes/commit/386e967cf00e77b203412c9dd12e57d56bb79cac
Although that is for bsnes 0.68 with a different directory hierarchy.. I will probably base future work on that version because it has PPU layer toggle unlike bsnes-classic.. CBA to pursue implementing such a feature on bsnes-classic...
073 has it too (Tools > Effect Toggle)...
UGH wish I knew that <_> Thanks :)
My master branch now has the extended customize-able keyboard shortcuts, full qt5 support, open-recent-romz support, autobreakpoint support (detailed under comments under the respective commit).
This is a useful feature to have. It adds an "Open Recent..." File submenu for loading files you've loaded in the past. 'nuff said (not really) .. I didn't test the feature with BSX/sufami turbo (I've never messed with that stuff), but it should work.. I opened a function that is used to load all types of cartridges based on file extension.. but I tested it with normal carts only. Seems to work. Be careful, could be broken. Try it out, you will love it :)
Note: I had to combine a commit from my previous pull request (Mandatory) for keyboard menu shortcuts, because they modify the same file.. Does that present problems? I am new to pull requests.