awjh / license-check-and-add

license-check-and-add
Apache License 2.0
11 stars 9 forks source link

Ignore the xml declaration line #56

Open francois-travais opened 3 years ago

francois-travais commented 3 years ago

Like for the bash shebang (#!), an xml declaration tag like so <?xml ?> should be the first instruction.

One drawback is that there's not necessarily a newline after <?xml ?>

awjh commented 3 years ago

Hello, apologies for the slow response. Do you think you could update this in a way that handles the fact there may not be a new line? There would also need to be tests around adding this, both unit and integration. I would suggest adding for the integration tests an xml file in the non-regex folder, one in the original files and one in the goal files.

Thank you for taking the time to PR into this project.